Comment 115 for bug 2004555
Revision history for this message
| Gorka Eguileor (gorka) wrote Re: [ussuri] Wrong volume attachment - volumes overlapping when connected through iscsi on host | #115 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0f7b58d
(Get the code!)
Brian thanks for the review, I have updated the patch with your suggestions (comment #111).
I may have changed the phrasing in a later patch than the one you reviewed, but I believe that in the latest one the api-ref, commit message, comments in code, and release note, all say the same thing, I just used different wording since the audience is different.
For example the release note is very brief and it reads: "cinder now rejects user attachment delete requests for attachments that are being used by nova instances".
Being used by a nova instance means that the instance exists, that it has the volume attached, and that the volume attachment in the instance is using that particular attachment.
Good call on the missing 409 response codes in the api-ref, unintentional deleted line on the test, etc.