Comment 2 for bug 1883490

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/735513
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=aed94a76cf62fdaedff793c7a9d998920b56c072
Submitter: Zuul
Branch: master

commit aed94a76cf62fdaedff793c7a9d998920b56c072
Author: Rajat Dhasmana <email address hidden>
Date: Mon Jun 15 07:10:05 2020 +0000

    Fix: listing volumes with filters

    This patch includes 2 fix for the following issues:

    1) ast.literal_eval() doesn't work with int and float values
    See comment inline

    2) Do not traverse and modify the same dict:
    while traversing filters dict, we're modifying it inside the loop
    which distorts the order of elements (adding modified elements in the
    end). to fix this, i've used a temp dict that will be used to traverse
    and modification will be done in the filters dict.

    Closes-Bug: #1883490

    Change-Id: I18b4b0b1b71904b766f7b89df49f5539e3c7662a