Cinder

  1. Bug #1838225
  2. Comment #6

Comment 6 for bug 1838225

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/673467
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2f0bd74604efe7f21823cba53b0a27f0ccc7ea12
Submitter: Zuul
Branch: master

commit 2f0bd74604efe7f21823cba53b0a27f0ccc7ea12
Author: Gorka Eguileor <email address hidden>
Date: Tue Jul 30 11:18:27 2019 +0200

    Fix get_driver_options

    Any new Cinder driver we add that doesn't have the "get_driver_options"
    method defined will break the driver list generation tools.

    The reason why it breaks them is because this method must be static, yet
    our base driver class doesn't define it as static.

    This patch:

    - Sets the base method as static to prevent new drivers from breaking
      the tools.

    - Documents the existence of this method for driver developers.

    - Adds get_driver_options method for drivers that are missing it.

    - Fix macrosan_client help message that breaks the doc building process.

    Closes-Bug: #1838225
    Change-Id: I4797724d7b55709f0903d522b0233242b867146d