Comment 19 for bug 1834845

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/queens)

Reviewed: https://review.opendev.org/685978
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2abd8a68bb1bde9adc7c870a1b827731ad4e42e9
Submitter: Zuul
Branch: stable/queens

commit 2abd8a68bb1bde9adc7c870a1b827731ad4e42e9
Author: Gorka Eguileor <email address hidden>
Date: Tue Jul 2 11:06:17 2019 +0200

    Fix DetachedInstanceError for VolumeAttachment

    Patch I253123d5451b32f0e3143916e41aaa1af75561c2 fixed the
    DetachedInstanceError for VolumeAttachment OVOs but only partially, as
    apparently it was dependent on the SQLAlchemy version due to the use os
    "hasattr".

    This patch replaces "hasattr" with a check on the object's dictionary,
    which will never trigger a Lazy Load.

    Closes-Bug: #1834845
    Change-Id: Iac785eef9be4b9cdb5c739ee0a87949805282867
    (cherry picked from commit 2e73bede80cc2acdb3527f06bc5c5f9c1a8463a7)
    (cherry picked from commit 44a15be6a71ebdaf0e5d1663fc31011ff43ef37b)
    Conflicts:
        cinder/tests/unit/volume/drivers/test_lvm_driver.py
    (cherry picked from commit eabf648b7acce33cb93d667e8f6e70505093b4c9)