Cinder

  1. Bug #1823750
  2. Comment #5

Comment 5 for bug 1823750

Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Hi,

The change on Cinder was abandoned, and so I suspect you agree that this isn't a bug in Cinder (as well)...

Summarizing from the discussion Vida pointed to above:

This check:

   200 >= resp.status < 300

effectively checks if

  resp.status ∈ [200, 299)

which means, "is the response from the WSGILimiterProxy service a 2xx status code [1]?"
The way this is written, the WsgiLimiterProxy that we're hitting returns a non 2xx when the API request must be rate limited. As such, I don't see any problem with this logic.

So, I'm setting this bug to Invalid, If you think otherwise, please let me know! :)

[1] https://tools.ietf.org/html/rfc7231#page-47