When online_data_migrations raise exceptions, nova/cinder-manage catches
the exceptions, prints fairly useless "something didn't work" messages,
and moves on. Two issues:
1) The user(/admin) has no way to see what actually failed (exception
detail is not logged)
2) The command returns exit status 0, as if all possible migrations have
been completed successfully - this can cause failures to get missed,
especially if automated
This change adds logging of the exceptions, and introduces a new exit
status of 2, which indicates that no updates took effect in the last
batch attempt, but some are (still) failing, which requires intervention.
Change-Id: Ib684091af0b19e62396f6becc78c656c49a60504
Closes-Bug: #1796192
(cherry picked from commit 3eea37b85b1abc72786a2b24baf01141b4d95f08)
Reviewed: https:/ /review. openstack. org/611701 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=dd8354efc11 13ae9f35e404ef5 ece00a78c378b4
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit dd8354efc1113ae 9f35e404ef5ece0 0a78c378b4
Author: imacdonn <email address hidden>
Date: Thu Oct 4 21:27:18 2018 +0000
Handle online_ data_migrations exceptions
When online_ data_migrations raise exceptions, nova/cinder-manage catches
the exceptions, prints fairly useless "something didn't work" messages,
and moves on. Two issues:
1) The user(/admin) has no way to see what actually failed (exception
detail is not logged)
2) The command returns exit status 0, as if all possible migrations have
been completed successfully - this can cause failures to get missed,
especially if automated
This change adds logging of the exceptions, and introduces a new exit
status of 2, which indicates that no updates took effect in the last
batch attempt, but some are (still) failing, which requires intervention.
Change-Id: Ib684091af0b19e 62396f6becc78c6 56c49a60504 2786a2b24baf011 41b4d95f08)
Closes-Bug: #1796192
(cherry picked from commit 3eea37b85b1abc7