This change converted a lock which locked on a
per-image basis to lock on a per-image+volume basis.
This defeats the point of having this lock, which was
to not perform the same image download operation more than
once, consuming unneeded network and storage resources.
This is not an especially strenuous or odd locking
pattern. If this causes tooz+etcd to fail, there is
likely a bug in tooz or etcd. There are many places in
Cinder that use locks like this one.
Related-Bug: #1705442
This reverts commit 35ae6fb90380a8e9db936827a4414cb249ef399b.
Reviewed: https:/ /review. openstack. org/488158 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=9b2a9407f7c 1b4688b9f696ea9 4677516bca5eba
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9b2a9407f7c1b46 88b9f696ea94677 516bca5eba
Author: Eric Harney <email address hidden>
Date: Thu Jul 27 15:17:38 2017 -0400
Revert "Handle concurrent volume creation request"
This change converted a lock which locked on a
per-image basis to lock on a per-image+volume basis.
This defeats the point of having this lock, which was
to not perform the same image download operation more than
once, consuming unneeded network and storage resources.
This is not an especially strenuous or odd locking
pattern. If this causes tooz+etcd to fail, there is
likely a bug in tooz or etcd. There are many places in
Cinder that use locks like this one.
Related-Bug: #1705442
This reverts commit 35ae6fb90380a8e 9db936827a4414c b249ef399b.
Change-Id: Ib00fcc61658f6b 1e59df66d387f31 01ea198d2e7