If --incremental flag is used and an incremental backup
fails, it should update the parent_id of the backup to
None.
Also for ceph driver, any backup after the first one
is an incremental backup automatically. Hence, the
is_incremental field for cinder backup-show <backup-id>
is misleading since it is set to False currently.
The patch correctly updates the parent_id for a
backup in case the incremental backup is successful.
If not, then it retains the parent_id as None. This
will also update the parent_id to None if incremental
backup fails even when --incremental flag is used.
Reviewed: https:/ /review. openstack. org/483089 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=f6cbcf46361 c49dc75c3fca2a2 65de734bfd2e61
Committed: https:/
Submitter: Jenkins
Branch: master
commit f6cbcf46361c49d c75c3fca2a265de 734bfd2e61
Author: Chaynika Saikia <email address hidden>
Date: Wed Jul 12 16:09:47 2017 -0400
cinder backup sets incorrect parent_id
If --incremental flag is used and an incremental backup
fails, it should update the parent_id of the backup to
None.
Also for ceph driver, any backup after the first one
is an incremental backup automatically. Hence, the
is_incremental field for cinder backup-show <backup-id>
is misleading since it is set to False currently.
The patch correctly updates the parent_id for a
backup in case the incremental backup is successful.
If not, then it retains the parent_id as None. This
will also update the parent_id to None if incremental
backup fails even when --incremental flag is used.
Change-Id: I22deff68d9376c 2ecc88bd2d9d0e1 b445d793123
Closes-Bug: #1703013