Remove useless response checks in SolidFire driver
The main issue_api_request method in the SolidFire driver
has had a mechanism to check validity of response data for
some time now. It checks the response and if there isn't
a valid result in the response it raises.
The problem is that we still have some cruft from the old
code that does local checking/verfication. These checks
won't ever actually be called because of the exception, and
they create some confusion.
This patch just removes those useless checks and cleans up
the api_request calls a bit.
Reviewed: https:/ /review. openstack. org/219756 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=3b90fc7e972 8c7eda45cf50259 e6c5d249b5d4c9
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3b90fc7e9728c7e da45cf50259e6c5 d249b5d4c9
Author: John Griffith <email address hidden>
Date: Wed Sep 2 15:56:15 2015 +0000
Remove useless response checks in SolidFire driver
The main issue_api_request method in the SolidFire driver
has had a mechanism to check validity of response data for
some time now. It checks the response and if there isn't
a valid result in the response it raises.
The problem is that we still have some cruft from the old verfication. These checks
code that does local checking/
won't ever actually be called because of the exception, and
they create some confusion.
This patch just removes those useless checks and cleans up
the api_request calls a bit.
Change-Id: Ifbcda0f943bb0b 9dc47aff25bbb92 45ce361fc48
Closes-Bug: #1491485