Comment 6 for bug 1365901

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/123469
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=59576bc73423f37466af4c7c511190a3d51d0449
Submitter: Jenkins
Branch: master

commit 59576bc73423f37466af4c7c511190a3d51d0449
Author: Matt Riedemann <email address hidden>
Date: Tue Sep 23 08:05:54 2014 -0700

    Remove usage of self.__dict__ for message var replacement

    This is the same as using locals() for variable replacement in a log
    message which violates hacking rule H501. On Cinder this actually
    caused the cinder-api process to hang on python 2.6.

    Nova has the same code so this fixes the hacking violation.

    Note that the H501 rule was updated in commit 55e96ee but it's not in a
    released version of hacking yet (and won't be in time for Juno).

    Closes-Bug: #1365901

    Change-Id: I1be0db327a2fa1e866328eecd2e7c3dd3ee3cc93