Cinder

  1. Bug #1346466
  2. Comment #11

Comment 11 for bug 1346466

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/167130
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=fb8c431ad6c7dd663ec1f251f55ba73067c3b6f5
Submitter: Jenkins
Branch: master

commit fb8c431ad6c7dd663ec1f251f55ba73067c3b6f5
Author: gtt116 <email address hidden>
Date: Tue Mar 24 07:43:34 2015 +0000

    Make notify driver messaging play well with publish_errors

    When publish_errors is True, and using `messaging` notify driver,
    produces a infinite loop that report sending notification error.

    The reason is we always passing None to the content argument in
    logger handlers (LoggingNotificationHandler, LoggingErrorNotificationHandler),
    when pack the context object which expected as a dict, raise TypeError
    exception, so result in infinite retry looping.

    To match what document said, passing a empty dict rather than None. Also
    modify unittests to make sure context is a empty dict.

    Change-Id: Ic2c4c43f5bbafa8107ea370ba959da16cfa4a24c
    Closes-bug: #1346466