Comment 6 for bug 1274245

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/76664
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cbe1d5f5e22e5f792128643e4cdd6afb2ff2b5bf
Submitter: Jenkins
Branch: master

commit cbe1d5f5e22e5f792128643e4cdd6afb2ff2b5bf
Author: Jay S. Bryant <email address hidden>
Date: Wed Feb 26 14:40:38 2014 -0600

    Remove str() from LOG.* and exceptions

    This commit removes the use of str() from LOG.* messages
    and exceptions.

    The reason we need to remove str() is because str() will fail if
    it gets a Unicode string that has something that doesn't translate
    to ASCII in it. If such a situation is encountered you will lose
    the message string in question. In most cases, the use of str() is
    unnecessary for LOG.* and exception messages. Using %s is smart
    enough to figure out what to do with what it is passed. It first
    tries to str() it, if this fails it falls back to using unicode. Either
    way, the result will then be something that gettextutils can
    handle and translate.

    Change-Id: I6eb81043edd9fa5e035d81ee81e8439340546d24
    Closes-bug: 1274245
    Related-bp: i18n-messages