In the `migrate_volume` method a new instance is created when the
dest_vg is not equal to the source vg. This new brick instance is
created using positional arguments instead of keywords. However, some of
those arguments are passed in the wrong positions.
This patch uses keywords for the misplaced arguments.
The patch also changes `test_lvm_migrate_volume_proceed` in order to
fully test the happy path and catch things like this.
Closes-bug: #1258128
(cherry picked from commit 69ce114232f9102220b45c8242eda3e78872a3e6)
Reviewed: https:/ /review. openstack. org/60956 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=f39441662d1 b6ffee65fe2e485 d6e0034682c5aa
Committed: https:/
Submitter: Jenkins
Branch: stable/havana
commit f39441662d1b6ff ee65fe2e485d6e0 034682c5aa
Author: Flavio Percoco <email address hidden>
Date: Thu Dec 5 13:48:24 2013 +0100
LVM migrate: Use keywords for the brick instance
In the `migrate_volume` method a new instance is created when the
dest_vg is not equal to the source vg. This new brick instance is
created using positional arguments instead of keywords. However, some of
those arguments are passed in the wrong positions.
This patch uses keywords for the misplaced arguments.
The patch also changes `test_lvm_ migrate_ volume_ proceed` in order to
fully test the happy path and catch things like this.
Closes-bug: #1258128 220b45c8242eda3 e78872a3e6)
(cherry picked from commit 69ce114232f9102
Conflicts: volume/ drivers/ lvm.py
cinder/
Change-Id: I75cf9117170955 4053fd5b52a4aae 4e176e8364e