Comment 2 for bug 1258128

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/60264
Committed: http://github.com/openstack/cinder/commit/69ce114232f9102220b45c8242eda3e78872a3e6
Submitter: Jenkins
Branch: master

commit 69ce114232f9102220b45c8242eda3e78872a3e6
Author: Flavio Percoco <email address hidden>
Date: Thu Dec 5 13:48:24 2013 +0100

    LVM migrate: Use keywords for the brick instance

    In the `migrate_volume` method a new instance is created when the
    dest_vg is not equal to the source vg. This new brick instance is
    created using positional arguments instead of keywords. However, some of
    those arguments are passed in the wrong positions.

    This patch uses keywords for the misplaced arguments.

    The patch also changes `test_lvm_migrate_volume_proceed` in order to
    fully test the happy path and catch things like this.

    Closes-bug: #1258128
    Change-Id: I75cf91171709554053fd5b52a4aae4e176e8364e