inadvertent type change to bootable in volume api summary view

Bug #1227837 reported by John Griffith on 2013-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
John Griffith

Bug Description

Change ID: Idd47a0a8069ee905b81c7aae562b82767ad91930 fixed a db query issue but one oversight was that we just pulled the setting of the bootable column directly from the returned volume object in cinder.api.v1:volumes._translage_volume_summary_view

This works and gives accurate info, however prior to this we had used strings "true" and "false", so now returning an actual True/False bool is a type change which is not allowed.

Fix proposed to branch: master
Review: https://review.openstack.org/47447

Changed in cinder:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/47447
Committed: http://github.com/openstack/cinder/commit/5d499395ac8028f4863e9a892453a197b254d384
Submitter: Jenkins
Branch: master

commit 5d499395ac8028f4863e9a892453a197b254d384
Author: John Griffith <email address hidden>
Date: Thu Sep 19 13:05:05 2013 -0600

    Fix type change in bootable setting of volume view

    Change Idd47a0a8069ee905b81c7aae562b82767ad91930 fixed a db
    query issue, by removing the image_metadata querie in the get/show
    methods.

    The problem however is that we just passed the setting from the volume
    object directly in the summary view builder. This results in changing
    the type of the value from a string "true/false" to a bool True/False
    which is no good.

    This patch converts the object member back to a string like it used to
    be so we don't break any compat or expectations in API behavior.

    Fixes bug #1227837

    Change-Id: I55c0e25134ae429802ddf313d6d26f1fad19ca94

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-04
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers