It's possible for the scheduler to send the periodic
stats update request *before* the volume service/driver
has finished initializing, resulting in an exception trace
being logged.
This change adds a check to verify that the vg is actually
initialized (completed check_for_setup_error) and it also
removes all of the duplication of each LVM class driver.
To deal with other drivers that may have similar issues,
add initialized member to base driver, that member is
set False on __init__ and is updated by the manager
after running check_for_setup_error. We also skip
update_stats if initialization isn't set True.
Rather than have a separate copy of update_stats in every
driver, we have one in the base LVM class and we set the two
unique variables as member parameters.
Reviewed: https:/ /review. openstack. org/45484 github. com/openstack/ cinder/ commit/ d552220a83052da abe19682b531bc6 b8e685a834
Committed: http://
Submitter: Jenkins
Branch: master
commit d552220a83052da abe19682b531bc6 b8e685a834
Author: John Griffith <email address hidden>
Date: Fri Sep 6 13:55:39 2013 -0600
Do not attempt vg.update on uninitialized vg
It's possible for the scheduler to send the periodic
stats update request *before* the volume service/driver
has finished initializing, resulting in an exception trace
being logged.
This change adds a check to verify that the vg is actually setup_error) and it also
initialized (completed check_for_
removes all of the duplication of each LVM class driver.
To deal with other drivers that may have similar issues, setup_error. We also skip
add initialized member to base driver, that member is
set False on __init__ and is updated by the manager
after running check_for_
update_stats if initialization isn't set True.
Rather than have a separate copy of update_stats in every
driver, we have one in the base LVM class and we set the two
unique variables as member parameters.
Fixes bug 1221874
Change-Id: I159e98a77782b8 b2c85a8dd956b15 0828358fd25