Logging configured incorrectly in cinder-all

Bug #1161038 reported by Neela Shah on 2013-03-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Low
Davanum Srinivas (DIMS)
Grizzly
Low
Chuck Short

Bug Description

To allow users to provide logging configuration options, the setup must be run before it gets the logger to ensure it does not always just default to the root logger.

So this order is important-
    logging.setup('cinder')
   LOG = logging.getLogger('cinder.all')

cinder-all is configuring logging incorrectly by reversing the order-
    LOG = logging.getLogger('cinder.all')
    logging.setup('cinder')

Fix proposed to branch: master
Review: https://review.openstack.org/25554

Changed in cinder:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress

Reviewed: https://review.openstack.org/25554
Committed: http://github.com/openstack/cinder/commit/3a106f7e67e4b7f7c446058b98c33f8c71ca2868
Submitter: Jenkins
Branch: master

commit 3a106f7e67e4b7f7c446058b98c33f8c71ca2868
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 27 15:17:44 2013 -0400

    getLogger should be called after logging is configured

    logging needs to be setup properly before we try to log
    something. Fixed one spot from logging->LOG

    Fixes LP# 1161038

    Change-Id: I87743cff9062e47c1d5e989c2c0c05c3921b65c7

Changed in cinder:
status: In Progress → Fix Committed
Neela Shah (neela) wrote :

Will this be backported to grizzly?

Neela Shah (neela) on 2013-04-03
tags: added: grizzly-backport-potential

Reviewed: https://review.openstack.org/26766
Committed: http://github.com/openstack/cinder/commit/ba41b6880aaff1f5f5e7e80b955516215af122ec
Submitter: Jenkins
Branch: stable/grizzly

commit ba41b6880aaff1f5f5e7e80b955516215af122ec
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 27 15:17:44 2013 -0400

    getLogger should be called after logging is configured

    logging needs to be setup properly before we try to log
    something. Fixed one spot from logging->LOG

    Fixes LP# 1161038

    Change-Id: I87743cff9062e47c1d5e989c2c0c05c3921b65c7
    (cherry picked from commit 3a106f7e67e4b7f7c446058b98c33f8c71ca2868)

tags: added: in-stable-grizzly
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
milestone: none → havana-1
status: Fix Committed → Fix Released
Alan Pevec (apevec) on 2013-08-06
tags: removed: in-stable-grizzly
Changed in cinder:
importance: Undecided → Low
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers