USB HDD verification seems to be working, yet it's marked as "No"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Brendan Donegan | ||
0.12 |
Invalid
|
Undecided
|
Unassigned | ||
Oneiric |
Invalid
|
Undecided
|
Unassigned | ||
checkbox (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Oneiric |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
I plugged an USB hard drive. All four partitions on it were mounted without problem. Yet, the test was marked as "No". I think everything is working fine, so I manually changed it to "Yes". But it's a bit unclear what is tested. Some people may keep the "No" answer, even if the partitions are mounted without any problem.
[Impact]
USB storage devices with multiple partitions confuse checkbox's usb_test script, which will falsely report the device is not working, thus hurting the system's Ubuntu Friendly score unfairly.
[Development fix]
The usb_test script is updated in revision 1119 to account for USB devices with logical partitions.
[Stable fix]
This is fixed in http://
[Test case]
- Prepare a USB stick with at least one logical partition (to really exercise the script, create at least one primary and one extended partition, with the latter containing at least two logical partitions). Format all the partitions and make sure they're all writable by the current user.
- Run /usr/share/
Expected result:
A test report that ends with "Successfully completed 1 USB file transfer test iterations".
Actual result:
Trace as reported in comment #5, ending in "IndexError: list index out of range".
[Regression potential]
This is just adding a safety check for a possible empty array, I don't think this could fail in any situation where it previously worked fine.
Related branches
- Daniel Manrique (community): Approve
-
Diff: 30 lines (+7/-3)2 files modifieddebian/changelog (+2/-0)
scripts/usb_test (+5/-3)
- Ubuntu Sponsors: Pending requested
-
Diff: 18858 lines (+9936/-3266)93 files modifiedcheckbox/application.py (+5/-5)
checkbox/contrib/persist.py (+5/-4)
checkbox/dispatcher.py (+201/-0)
checkbox/lib/bit.py (+5/-4)
checkbox/lib/config.py (+15/-2)
checkbox/lib/conversion.py (+131/-42)
checkbox/lib/dmi.py (+169/-18)
checkbox/lib/safe.py (+5/-0)
checkbox/lib/template.py (+1/-1)
checkbox/message.py (+4/-3)
checkbox/parsers/cpuinfo.py (+30/-41)
checkbox/parsers/cputable (+40/-0)
checkbox/parsers/cputable.py (+42/-0)
checkbox/parsers/deferred.py (+27/-0)
checkbox/parsers/dmidecode.py (+123/-0)
checkbox/parsers/meminfo.py (+46/-0)
checkbox/parsers/submission.py (+474/-383)
checkbox/parsers/udevadm.py (+178/-317)
checkbox_cli/cli_interface.py (+9/-1)
checkbox_gtk/gtk_interface.py (+4/-4)
data/whitelists/default.whitelist (+1/-0)
debian/changelog (+59/-0)
debian/po/ro.po (+118/-0)
examples/checkbox.ini (+1/-1)
gtk/checkbox-gtk.ui (+37/-37)
jobs/apport.txt.in (+0/-5)
jobs/audio.txt.in (+44/-24)
jobs/autotest.txt.in (+4/-2)
jobs/bluetooth.txt.in (+64/-52)
jobs/camera.txt.in (+19/-12)
jobs/codecs.txt.in (+16/-38)
jobs/cpu.txt.in (+3/-3)
jobs/daemons.txt.in (+11/-11)
jobs/disk.txt.in (+6/-5)
jobs/evolution.txt.in (+0/-26)
jobs/fingerprint.txt.in (+24/-20)
jobs/firewire.txt.in (+9/-8)
jobs/gcalctool.txt.in (+0/-52)
jobs/gedit.txt.in (+0/-22)
jobs/gnome-terminal.txt.in (+0/-12)
jobs/graphics.txt.in (+63/-51)
jobs/hibernate.txt.in (+9/-7)
jobs/info.txt.in (+47/-27)
jobs/input.txt.in (+15/-7)
jobs/install.txt.in (+1/-1)
jobs/keys.txt.in (+58/-45)
jobs/local.txt.in (+41/-6)
jobs/ltp.txt.in (+3/-2)
jobs/mago.txt.in (+4/-2)
jobs/mediacard.txt.in (+106/-84)
jobs/memory.txt.in (+8/-5)
jobs/miscellanea.txt.in (+19/-8)
jobs/monitor.txt.in (+43/-24)
jobs/networking.txt.in (+31/-32)
jobs/optical.txt.in (+56/-42)
jobs/panel_clock_test.txt.in (+18/-15)
jobs/panel_reboot.txt.in (+8/-6)
jobs/pcmcia-pcix.txt.in (+6/-3)
jobs/peripheral.txt.in (+27/-22)
jobs/phoronix.txt.in (+4/-2)
jobs/power-management.txt.in (+32/-18)
jobs/qa_regression.txt.in (+4/-2)
jobs/resource.txt.in (+15/-0)
jobs/screenshot.txt.in (+0/-13)
jobs/server-services.txt.in (+12/-12)
jobs/stress.txt.in (+18/-10)
jobs/suspend.txt.in (+52/-31)
jobs/usb.txt.in (+55/-36)
jobs/user_apps.txt.in (+337/-110)
jobs/wireless.txt.in (+9/-9)
plugins/apport_prompt.py (+1/-1)
plugins/launchpad_report.py (+6/-4)
plugins/persist_info.py (+2/-1)
plugins/resource_info.py (+14/-1)
plugins/system_info.py (+2/-2)
po/POTFILES.in (+0/-6)
po/ca@valencia.po (+2897/-0)
po/el.po (+229/-293)
po/en_GB.po (+240/-240)
po/gd.po (+2606/-0)
po/ja.po (+297/-335)
po/lt.po (+294/-357)
po/tr.po (+217/-177)
scripts/connect_wireless (+1/-1)
scripts/cpuinfo_resource (+13/-17)
scripts/dmi_resource (+55/-0)
scripts/hal_resource (+0/-5)
scripts/meminfo_resource (+15/-27)
scripts/package_resource (+6/-0)
scripts/udev_resource (+2/-2)
scripts/usb_test (+5/-3)
setup.cfg (+1/-7)
setup.py (+2/-0)
- Luke Yelavich (community): Approve
-
Diff: 279 lines (+82/-54)10 files modifiedcheckbox/contrib/persist.py (+5/-4)
checkbox/lib/safe.py (+5/-0)
checkbox/message.py (+4/-3)
checkbox_gtk/gtk_interface.py (+2/-4)
debian/changelog (+20/-0)
gtk/checkbox-gtk.ui (+37/-37)
jobs/input.txt.in (+1/-1)
plugins/persist_info.py (+2/-1)
scripts/connect_wireless (+1/-1)
scripts/usb_test (+5/-3)
affects: | ubuntu-friendly → checkbox |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
description: | updated |
description: | updated |
Changed in checkbox (Ubuntu Oneiric): | |
status: | Fix Committed → Won't Fix |
I had the same experience on this test section, I think it has to do with
mounted drives no longer showing on the desktop and just needs to be
updated to reflect this. But it is very unclear and at quick glance I
suspect most testers would let it stay marked as a Fail.
2011/11/7 Mike Heald <email address hidden>
> ** Project changed: ubuntu-friendly => checkbox /bugs.launchpad .net/bugs/ 887049 /bugs.launchpad .net/checkbox/ +bug/887049/ +subscriptions
>
> --
> You received this bug notification because you are a member of Ubuntu
> Friendly Squad, which is subscribed to Ubuntu Friendly.
> https:/
>
> Title:
> USB HDD verification seems to be working, yet it's marked as "No"
>
> Status in Checkbox System Testing:
> New
>
> Bug description:
> I plugged an USB hard drive. All four partitions on it were mounted
> without problem. Yet, the test was marked as "No". I think everything
> is working fine, so I manually changed it to "Yes". But it's a bit
> unclear what is tested. Some people may keep the "No" answer, even if
> the partitions are mounted without any problem.
>
> To manage notifications about this bug go to:
> https:/
>
--
Cheers,
Bob Bolin