Presuming that after 'z' will come 'a' - with regard to distro codename, several charms are about to have unintended behavior due to the use of alpha comparison logic. The numeric version comparison should be used instead.
I've not done a full audit of all OpenStack Charms but that needs to be done as soon as possible, and associated with this bug.
Presuming that after 'z' will come 'a' - with regard to distro codename, several charms are about to have unintended behavior due to the use of alpha comparison logic. The numeric version comparison should be used instead.
I've not done a full audit of all OpenStack Charms but that needs to be done as soon as possible, and associated with this bug.
Here are a some examples which need to be fixed:
https:/ /github. com/openstack/ charm-nova- compute/ search? utf8=%E2% 9C%93&q= distro_ codename
distro_codename = lsb_release( )['DISTRIB_ CODENAME' ].lower( ) 'nova-common' )
release = os_release(
# NOTE(jamespage): deal with switch to systemd
if distro_codename < "wily":
distro_codename = lsb_release( )['DISTRIB_ CODENAME' ].lower( )
if distro_codename >= 'yakkety':
return LIBVIRTD_DAEMON
.
Here is an example of the safe way to do it:
https:/ /github. com/openstack/ charm-nova- cloud-controlle r/search? utf8=%E2% 9C%93&q= DISTRIB_ RELEASE& type=Code
bin_dir = os.path. join(git_ pip_venv_ dir(projects_ yaml), 'bin') )['DISTRIB_ RELEASE' ] >= '15.10':
# Use systemd init units/scripts from ubuntu wily onward
if lsb_release(