Comment 0 for bug 1503340

Revision history for this message
Ryan Beisner (1chb1n) wrote :

<beisner> coreycb, thedac - i'm on a normalize-makefiles mission for *os-charms. noticing that some charms aren't lint checking the actions/ dir. when i enable that, some of them have unused uuid import in actions/openstack_upgrade.py
<beisner> and when i remove that import, unit tests start to fail with 'actions/openstack_upgrade.py'> does not have the attribute 'uuid'
<coreycb> beisner, I'd mark that low priority for now
<thedac> agreed
<beisner> coreycb, thedac - if i move forward, we'll either have failing lint checks or failing unit checks.
<beisner> i can just ignore the actions dir for now ?
<coreycb> beisner, yeah I'd vote for that and a bug
<thedac> Yes, I would not make the change (yet) that checks the actions directory
<beisner> fwiw, some do have it lint checks on the actions/ dir enabled, though for the pause/resume actions
<beisner> be aware ^
<beisner> so that'll force the next guy to make it right ;-)
<beisner> on those ones