Comment 2 for bug 997339

Hi Khairul:

Thank you very much for the charm . This is very cool indeed!

I encourage you to run charm proof on your charm before submitting for review as it normally catches things that we all tend to forget from time to time.

I ran charm proof on your charm and this is what I found:

W: metadata name (openbravo3) must match directory name (openbravo) exactly for local deployment.
- Not really critical but it has been a convention that we would like to keep

E: Charms need a maintainer (See RFC2822) - Name <email>
- We now require that charms have a maintainer field in the metadata.yaml file. Yours would look something similar to:
  maintainer: Khairul Kamarudzzaman <email address hidden>

E: no copyright file
- We also need the charm to have a copyright file ( charm get mongodb for an example of a copyright file )

E: template relations should be renamed to fit charm: relation-name
E: template interface names should be changed: interface-name
E: template relations should be renamed to fit charm: relation-name
E: template interface names should be changed: interface-name
E: template relations should be renamed to fit charm: relation-name
E: template interface names should be changed: interface-name
- All of these need to be cleaned up in the metadata.yaml file ( rename the interfaces to something relevant to your charm ) and in the hooks directory ( each interface in metadata.yaml file should have a corresponding set of one or more hooks )

I also noticed that you hard-coded port 80 on install file. Consider adding a config.yaml file where you can put this and any other values that could have a default but, can also be changed by the users ( charm get mongodb for an example of how to use config.yaml in your charms )

I would be happy to review your charm once the above issues have been addressed. Just change the bug status to "Fix Committed" when done.

Thanks,

Juan