Comment 1 for bug 996905

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

David, this is *awesome*. Just *awesome*.

I do not have an account with any of the supported providers, so I was not able to fully test, but nothing "breaks" and it does try to register the hostname when I relate it.

This is one of the cooler things I've seen done w/ subordinates. Its almost ready for promulgation.

 I just want to make sure the config options are set properly so we don't have to go back and change them, as that is hard on users.

The 'daemon' config option is very confusing. It doesn't actually describe what the option does, which is set the delay. How about 'refresh-interval' ? Also make it type: int, and default: 300, as it can't really be a string.

Please fix that, and I will promulgate it right away.

== Other feedback ==

* Consider running the juju-info-relation-joined hook again from config-changed. You can do this with the 'relation-ids' command, but its non-trivial. Basically you would do this:

for JUJU_RELATION_ID in `relation-ids juju-info` ; do
  export JUJU_RELATION_ID
  for JUJU_REMOTE_UNIT in `relation-list -r $rel` ; do
    export JUJU_REMOTE_UNIT
    hooks/juju-info-relation-joined
  done
done

This will allow you to change the config parameters after the relationships have been established.