Comment 1 for bug 994699

Hi Brandon. Thanks for submitting another full-featured charm. :)

Blockers:

* No maintainer -

$ charm proof
E: Charms need a maintainer (See RFC2822) - Name <email>

* NFS relation does nothing

I: relation nfs has no hooks

* readme doesn't explain how to actually use the charm

I really don't know what to do with this charm. Is it just for forking into other charms? I'm not sure what this charm gives me beyond 'apt-get install nginx'. Please explain this in readme.

Style questions:

* Using php, but then not using php?

run('mkdir -p /mnt/ramdisk/phpfpm-cache');
run('mkdir -p /mnt/ramdisk/tmp-cache');
run('mkdir -p /mnt/www');

Why are you using 'run' instead of just the 'mkdir' function?

* Wrong word in template

## placed by juju, do not edit or you will loose your changes

I suspect that should be 'will lose your changes'

* Using templates, but with static only values

$options = array('webroot');
$values = array('/mnt/www');
$default_site = template::replace($options,$values,template::read('default'));
template::write('/etc/nginx/sites-enabled/default',$default_site);

This seems.. fairly confusing. Whats the idea there?

* Using a non standard templating language

I'm not sure we should allow full implementations of templating in individual charms... heredocs or something established would make a lot more sense.

Setting to Incomplete until issues are addressed.