Comment 5 for bug 950968

... and after all the work I do for you :)

j/k Thanks for the review ... You are right .. I have work to do so I'll
get to it.

Thanks,

Juan

On Wed, May 23, 2012 at 3:43 PM, Clint Byrum <email address hidden> wrote:

> Hi Juan. I love gearman, great service. This is a cool idea, and I think
> in the near future we will want gearman server for scaling out nagios,
> which can use it to scale.
>
> Anyway, here are some blockers:
>
> * pecl is not crypto-verified-safe. You should just download the tarball
> into the charm, and pecl-build it.
>
> * Looks like you mixed up variable names between PORT and DEFAULT_PORT,
> deploy produced this error:
>
>
> 2012-05-23 15:33:35,804 unit:gearman-server/0: hook.output ERROR: + echo
> extension=gearman.so
> + sed -e 's/^ENABLED=.*/ENABLED="true"/' -i /etc/default/gearman-server
>
> 2012-05-23 15:33:35,809 unit:gearman-server/0: hook.output ERROR: + '[' -x
> /usr/bin/open-port ']'
> /var/lib/juju/units/gearman-server-0/charm/hooks/install: line 50:
> DEFAULT_PORT: unbound variable
>
> 2012-05-23 15:33:35,809 unit:gearman-server/0: hook.output DEBUG: hook
> install exited, exit code Traceback (most recent call last):
> Failure: juju.errors.CharmInvocationError: Error processing
> '/var/lib/juju/units/gearman-server-0/charm/hooks/install': exit code 1.
> .
> 2012-05-23 15:33:35,809 unit:gearman-server/0: hook.executor DEBUG: Hook
> error: /var/lib/juju/units/gearman-server-0/charm/hooks/install Error
> processing '/var/lib/juju/units/gearman-server-0/charm/hooks/install': exit
> code 1.
>
> * start/stop hooks in gearman-worker are boilerplate, other hook scripts
> have boilerplate comments in them.
>
> * both open a port, but that doesn't make sense as only the server
> should need to open a port.
>
> Minors:
>
> * I don't see why we install the pecl extension on the server.
>
> * The client seems to just be a framework that doesn't actually start
> workers.
>
> * README should not reference your personal branches
>
> * README says to expose the server, but there's no apparent reason for
> that.
>
> Other:
>
> * Gearmand actually works via HTTP as well if you tell it to. That might
> be a nice option to expose so that users can write web apps that AJAX
> directly to gearmand
>
> * Gearmand has persistent queue options that can write to a database so
> jobs aren't lost (sqlite, redis, postgres, mysql, drizzle,
> tokyocabinet). That would be a good option to allow users to make use of
> or maybe even default to since it is safer that way.
>
> Anyway, looks like you've got some work to do. :)
>
> ** Changed in: charms
> Status: In Progress => Incomplete
>
> --
> You received this bug notification because you are a member of charmers,
> which is subscribed to the bug report.
> https://bugs.launchpad.net/bugs/950968
>
> Title:
> Charm needed: gearman
>
> Status in Juju Charms:
> Incomplete
>
> Bug description:
> Need a gearman ( http://www.gearman.org ) charm.
>
> -Juan
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charms/+bug/950968/+subscriptions
>