Comment 1 for bug 944246

Revision history for this message
Jorge Castro (jorge) wrote :

This isn't a real review because I'm not a reviewer, but I talked to Ben on IRC:

- needs an open-port statement for the port.
- needs some -y's around some of the apt-get's
- needs a more descriptive readme.

Since juju doesn't do subordinates yet and it's a chat client I think leaving mongo and node in this charm is fine, we don't need 4 instances to run an irc client. This charm will be slick though.

Ben when you've pushed the things we've talked about flip the status to Fix Committed to get it back in the queue, thanks!