Comment 5 for bug 942032

Adam,

Thank you for your submission for the ReviewBoard charm. It looks really good, and I'm excited about having ReviewBoard in the store, since it's a great code review tool.

I was able to deploy your charm without issue by following the README, which is complete and informative. Charm proof also passes without warnings or errors. The hooks code is nice and clean and handles idempotency issues well.

The one issue that I see with the charm is that, although documented, having config options that don't respect post-deployment changes is a big issue, since it prevents the user from being able to admin the software via the standard charm interfaces. I understand the difficulty with ReviewBoard not exposing great interfaces for managing the admin password and host name, but I think it would be worth finding a way to support the changes. For example, you could possibly use `rb-site manage /var/www/reviewboard changepassword admin` to update the admin password. Setting the host name, though, may require issuing a SQL command to postgresql, so it might be easier to implement both in that fashion.

Thanks again for the submission. I'm going to change status of this bug to "incomplete" and when you're ready for another review please change the status of the bug to "fix submitted" or "new" and someone will be along shortly to review your changes.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net  or email the mailing list <email address hidden>