Comment 2 for bug 918803

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Hi Clint, thanks for the review!

I addressed most of your points. Here's the summary:

1) Added a copyright file. I copied the one from postgresql and changed it to be AGPL as that's the license for oops-tools. Let me know if that's ok and if the format is correct.

2) Done

3) Files and dirs need to be world readable so apache can read them and serve through mod_wsgi. I changed how the file permissions are set to make directories world readable and executable and files world readable. Is this ok?

4) I removed the sed edits from the file and will land a change directly on oops-tools trunk to provide an apache virtual host file that doesn't need those changes. See https://pastebin.canonical.com/59088/ for the changes I'm going to propose to oops-tools trunk.

5) We deploy it directly from trunk and never had the need/time to package this properly. I think what you suggest is a good idea, but I'll leave it for another time.