Comment 8 for bug 901927

Hi Jerry:

Thanks for taking the time to continue to update the charm.

== Blockers ==
- We recently added a requirement for charms to have a maintainer field in the metadata.yaml
  It would look something like:
  maintainer: Jerry Seutter <email address hidden>
  As a rule of thumb, it's a good idea to run charm proof ( charm proof <charm> ) before submitting.
  It tries to keep up with changes to the rules as well as new things we find need to be tested.

== Non Blockers ==
- One thing you can do with the freeciv-service hook would be to create a simple join hook that adds it's IP to the realtionship ( relation-set host=`unit-get private-address` ) just to satisfy the hook. I understand that this is a self contained charm but, in the future, we can come up with ways of using this charm ( I think ) that may take advantage of the hos/ip being exported in a relation . That's one of the cool things about Juju and charms, we expose information about a service and some other unrelated charm can just use it.

Just my two cents ...

Adding the maintainer field to the metadata.yaml file would take care of the blockers and I can review/approve when ready.

Thanks,

Juan