© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hi:
Some feedback on the charm. charm proof freeciv outputs the following:
W: no README file
I: relation freeciv-service has no hooks
Charms need to have a README file. It's nice when we have a README file that explains what the charm does and how it should be used. Also an explanation of the different options that could be configured in it.
One of the great advantages of juju is it's ability to connect services to one another based on relationships. Hooks are the way we initiate the relationships on each charm. Each charm should provide ( or maybe require ) something that has a hook associated with it.
This may or may not apply to _every_ charm ( hence the information and not warning or fatal ).
In this case, the metadata.yaml file specifies a freeciv-service relation that has no hook.
All in all the charm, deploys, works and it's very interesting.
If you can fix the issues above and resubmit, I would be happy to review again.
-Juan