© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Hi Jerry,
Great job on getting this charm up! I went through and reviewed was was done so far and have a few items of feedback for you :) First off, this is an awesome charm, I know I'll be using it frequently!
1) There doesn't appear to be any way to configure the Freeciv server except for the defaults in the freeciv-server package. Consider setting up a config-changed hook and config.yaml[1] file to allow users to update settings[2] for the server. You have a bunch of different options in regards to this:
a) Explicitly list all the logical configuration options in a config.yaml file so users can juju set <option=val> which would then execute them in the running screen instance
b) Create a config option for a "command-line user" so an in-game user can be specified as an admin
c) A mixture of the two, some of the vital options abstracted to command-line and the ability to add cli user which can update the rest in game.
In order for this to be a rock solid charm though, some form of configuration would be required, IMO.
2) You don't need to killall freeciv-server from the start hook since start hook is only run once by juju.
/** None vital, but something to consider **/
3) You might want to create an upstart script for freeciv-server, though given the nature of the charm it would probably be more trouble than pay-off since the service never needs to be restarted for configuration updates, like Apache and other services.
So far a great start to a sweet charm!
[1]: https:/
[2]: http://