© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
eee2d0b
(Get the code!)
Hi James,
Ok, my first charm review...
stopper:
- needs some sort of license (I just grab them from other charms)
recommendations
- the install hook looks simple and straightforward. It might be useful to log the setup installs since you're installing from a branch and not a package as that's more likely to fail over time. Doesn't really matter though because either way you'll know it failed.
- no need to open internal ports (2003) unless you intend for them to be external someday. Everything's open internally for the foreseeable future.
- maybe use an upstart script for your service to survive reboots? I'd test a failed startup, you might need a 'set -e' for the start hook to catch a startup error from the subshell correctly... dunno.