stopper:
- needs some sort of license (I just grab them from other charms)
maybe a stopper(?):
- metadata says requires carbon, but there're no hooks for that relation. Sorry, I don't know if that's a stopper for actual promulgation or not. Does the charm do a whole lot without that hook?
recommendations/discussion:
- metadata:description... we should copy the summary again at the very least. maybe even blank?
- no need to open internal ports (8125) unless you intend for them to be external someday. Everything's open internally for the foreseeable future.
- maybe use an upstart script for your service to survive reboots?
- maybe pick some standard place to install the service (/usr/local, /opt, or even /usr)? It'd make it easier for someone else to come along and see the branch, scripts, pid-files, logs, etc when debugging.
stopper:
- needs some sort of license (I just grab them from other charms)
maybe a stopper(?):
- metadata says requires carbon, but there're no hooks for that relation. Sorry, I don't know if that's a stopper for actual promulgation or not. Does the charm do a whole lot without that hook?
recommendations /discussion:
- metadata: description. .. we should copy the summary again at the very least. maybe even blank?
- no need to open internal ports (8125) unless you intend for them to be external someday. Everything's open internally for the foreseeable future.
- maybe use an upstart script for your service to survive reboots?
- maybe pick some standard place to install the service (/usr/local, /opt, or even /usr)? It'd make it easier for someone else to come along and see the branch, scripts, pid-files, logs, etc when debugging.