Comment 3 for bug 853910

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi James, thanks for the quick review.

1) Easy enough to handle. Added a call to hooks/apply to collectd-relation-joined .. now the facts will be updated (and the template relation-sets using @config_security_level).

2) done, this also made me look again and I realized the port was not actually being used, so there are some major changes in revision 9 to make that work.

3,4) There is no way to handle arrays in puppet's language. You'll notice the lack of the word 'loop' here http://docs.puppetlabs.com/guides/language_guide.html.

I think these things are fairly straightforward, though I agree templates seems wrong for this.

In the future I'll be experimenting with using the puppet ruby DSL instead of .pp files, and that will allow for this level of interaction outside of templates. Another option is to write a juju resource provider for puppet, but that will take some time to get right, and at some point will have diminishing returns I think.