Comment 7 for bug 799879

Hi Mark!

Got a few things I noticed while going through the app, otherwise seriously sweet charm!

# Items
* config-samples/myapp.yaml uses an insecure protocol
* config.yaml repo_type is ambiguous (git/bzr/...) should likely have an explicit lists of acceptable VCS tools since things like svn, hg, etc are not supported.
* Readme has old paths (etc/sample-config.yaml)
* PostgreSQL ruby is installed, but the libpq-dev package isn't. pg gem won't build without this.
* MySQL db relations fail with the following message: http://paste.ubuntu.com/1159576/ setting HOME to /home/ubuntu should resolve this.

# Discussion
* The charm doesn't allow any flexibility of installing additional packages which might be required for a gem to be installed (imagemagik, rmagic, pgsql, etc). This might be a config option? Or possibly just require the user to fork the charm.
* All of the logic, including the configuration logic, is in the install hook. Is it by design that this charm can only be configured during deployment? If so, then having all the config calls in the install hook makes sense. If this charm will ever be set up to allow for dynamic application switching on the fly (deploy foo app; later, change to baz) then this will need to be changed to the config-changed hook. A warning in the readme about this usage would probably be beneficial

# Future?
* Since pgsql is installed, it would be nice to see it as a relation in future versions of this charm

I installed a few different rails apps, from as basic as one I wrote quickly to as complex as Redmine and the charm seems to cover most of the bases, with the exception of the few items above.