Comment 3 for bug 1612535

Revision history for this message
Pen Gale (pengale) wrote :

Hi There,

I spent some time reviewing this charm today. Thank you for slinging the files over to me, and thank you for your work in general on the charm!

I ran into a few issues:

1) Layer-ibm-im and interface:was-ihs missing from registry interfaces.juju.solutions so we could not build the ibm-http layer. We saw the following errors from the charm build process:
build: Unable to locate layer:ibm-im. Do you need to set LAYER_PATH?
build: Unable to locate interface:was-ihs. Do you need to set INTERFACE_PATH?

@kwmonroe fixed this for you, but you can upload these layers yourself (without a review) by going to http://interfaces.juju.solutions/ logging in with your LaunchPad (LP) credentials. Click on the + sign for interfaces and fill in the fields. The key field is the “repo” which is a URL to the layer repository in launchpad.

Do the same procedure to add an interface.

2) The README.md was unclear on which files to provide as resources. In addition to the files mentioned in the README, you need to grab the ibm-im installer, and pass it as the first resource. I figured it out with the help of someone experienced with deploying similar charms, but someone reading through the README, with no outside assistance, is likely to get stuck.

3) The list of licenses to agree to in the README is outdated.

I'm currently working on getting this charm deployed for testing alongside ibm-was. It would be useful to have a link to the docs on setting up ibm-was in the README.