Comment 3 for bug 1538573

Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Thank you for taking the time to address the comments we had.

The tests run without any issue. We are missing a couple of minor fixes:
- The use_venv flag should go to the layers.yaml file not in metadata.yaml this was detected by charm proof.
- Style problems detected by make lint indicate we do not have any unit_test. We can silence that by providing a Makefile other than the one inherited by the basic layer. For other style problems inherited by the nrpe interface we contacted the author and they have been already fixed!

Please, consider merging the patch we offer on this branch:
https://code.launchpad.net/~kos.tsakalozos/collectd/almostthere

Thanks,
Konstantinos