Comment 4 for bug 1515717

Greetings Anton, I’ve taken some time to review the Nexenta NEDGE stack. This is a great first round submission. I’ve run across some points that will need to be addressed before the charms are ready to pass policy for the charm store. I encourage you to review the submission process documents to familiarize yourself with what we will be checking during the review: https://jujucharms.com/docs/stable/authors-charm-policy

** note about charm proof - Anything above an I: will need to be addressed. W:s and E:s are both treated as errors. This is confusing I know, please send a message to the juju mailing list (<email address hidden>) if you agree and wish this to be changed.

NedgeMGMT

This charm has some lint errors
https://gist.github.com/a04f1545b16a3627dcbf

When proofing the charm, there is a leftover README.example.md file leftover in the repository and can safely be deleted as there is a well formed README in the charm.

I gripped through the license and see you have included an EULA in the file, which is great. There also needs to exist some verbiage about the charm code being licensed under a suitable OSI approved license.

Cinder Nedge

this charm has some lint errors:
https://gist.github.com/bf6088cea347a49e04a5

proof output:

W: summary should be less than 72
W: no README file
E: config.yaml: options section is not parsed as a dictionary

Includes a juju-info relationship. These relationships are implicit in Juju, and the relation should not be named Juju-Info. Perhaps the following is a valid candidate for replacement?

cinder-host:
  interface: juju-info
  scope: container

it also appears that you left in some of the boilerplate metadata. I’ve proposed some updates, left the comment above about the relationship, and proposed some proof cleanups. Its not 100% clean but should get you much closer 😃

Nedge-swift-gw
This charm has some lint errors
https://gist.github.com/e90234057202f8b9a903

Nedge:
charm proof
W: no copyright file

Looks like we are missing the copyright file, each charm must be licensed under an OSD approved license.
https://jujucharms.com/docs/stable/authors-charm-policy

this charm has some lint errors:
https://gist.github.com/fb389568fad15d20aa34

nedge-cinder-gw

This charm has some lint errors:
https://gist.github.com/71acbb0319348b28d333

I'm going to move the status of this bug to "incomplete"

Once you have addressed the above review comments, please move the status of the bug to "fix committed" and someone will be along shortly to give you another review.

ou have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.