Comment 6 for bug 1459345

Revision history for this message
Cory Johns (johnsca) wrote :

Another issue I hit, which is more of a bug in bundletester but which could be fixed easily with some simple changes to the Makefile, is that bundletester doesn't work well with .PHONY targets; it just skips them. So, when running bundletester for the first time, before the .venv is set up, it skips the .PHONY setup target and thus doesn't create the .venv. By simply removing the setup target and having the other targets refer directly to $(VENV_ACTIVATE) we can work around the issue in bundletester.

With that and the other suggested changes from my previous comment, I was able to get bundletester to run and everything passed. Charm proof, the icon, the README, metadata.yaml, copyright, and all also look good. The charm code itself looks good, as well. So, other than the aforementioned pain points with getting this working with bundletester (and thus the automated test runner), this charm seems good to me.