The nova-cloud-controller charm branch has been updated inline with my previous feedback, so this charm needs an update.
b) neutron-api install failure
unit-neutron-api-0[9625]: 2015-12-17 10:19:06 INFO unit.neutron-api/0.install logger.go:40 Reading package lists...
unit-neutron-api-0[9625]: 2015-12-17 10:19:06 INFO unit.neutron-api/0.install logger.go:40 Building dependency tree...
unit-neutron-api-0[9625]: 2015-12-17 10:19:06 INFO unit.neutron-api/0.install logger.go:40 Reading state information...
unit-neutron-api-0[9625]: 2015-12-17 10:19:06 INFO unit.neutron-api/0.install logger.go:40 E: Unable to locate package python-neutron-plugin-midonet
unit-neutron-api-0[9625]: 2015-12-17 10:19:06 INFO unit.neutron-api/0.juju-log server.go:254 Couldn't acquire DPKG lock. Will retry in 10 seconds.
This actually related to a network access problem that I had - once that was sorted out, I was able to get the neutron-api service running; however it does highlight a bug in the neutron-api charm (apt_update is called in non fatal mode):
No action required as part of this review - we'll get that fixed under separate cover.
c) switch tests to use landed midonet changes
We still have outstanding changes for neutron-api and nova-cloud-controller, but keystone and nova-compute can use the main charm-store charms now I think.
d) memory requirements for units
Anything with midonet-agent installed appears to need > 2G of RAM to actually operate as the java heap size for midolman is not dynamically configured based on avaliable memory.
I increased the mem constraint on the services that use this sub to work around that in my testenv (default unit only has 1.5G of RAM).
host-relation-changed was never returning - this causes the amulet tests to hang as the state on the agent sticks a 'executing'
f) midonet-agent on nova-compute
midolman never actually go installed - this is not propagated back to the charm, so the deployment looks OK, but its not actually complete.
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[1;31mError: /Stage[main]/Midonet::Midonet_agent::Install/Package[midolman]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install midolman' returned 100: Reading package lists...
2015-12-17 12:30:01 INFO zookeeper-relation-changed Building dependency tree...
2015-12-17 12:30:01 INFO zookeeper-relation-changed Reading state information...
2015-12-17 12:30:01 INFO zookeeper-relation-changed E: Unable to locate package midolman
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[0m
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[mNotice: /Stage[main]/Midonet::Midonet_agent::Run/File[/etc/midolman/midolman.conf]: Dependency Package[midolman] has failures: true^[[0m
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[1;31mWarning: /Stage[main]/Midonet::Midonet_agent::Run/File[/etc/midolman/midolman.conf]: Skipping because of failed dependencies^[[0m
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[mNotice: /Stage[main]/Midonet::Midonet_agent::Run/Service[midolman]: Dependency Package[midolman] has failures: true^[[0m
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[1;31mWarning: /Stage[main]/Midonet::Midonet_agent::Run/Service[midolman]: Skipping because of failed dependencies^[[0m
2015-12-17 12:30:01 INFO zookeeper-relation-changed ^[[mNotice: Finished catalog run in 0.50 seconds^[[0m
Any changes I made to the amulet tests I've proposed back to you under:
midonet-api::Amulet Tests
Had a few problems executing the amulet tests.
a) shared_secret -> shared-secret
The nova-cloud- controller charm branch has been updated inline with my previous feedback, so this charm needs an update.
b) neutron-api install failure
unit-neutron- api-0[9625] : 2015-12-17 10:19:06 INFO unit.neutron- api/0.install logger.go:40 Reading package lists... api-0[9625] : 2015-12-17 10:19:06 INFO unit.neutron- api/0.install logger.go:40 Building dependency tree... api-0[9625] : 2015-12-17 10:19:06 INFO unit.neutron- api/0.install logger.go:40 Reading state information... api-0[9625] : 2015-12-17 10:19:06 INFO unit.neutron- api/0.install logger.go:40 E: Unable to locate package python- neutron- plugin- midonet api-0[9625] : 2015-12-17 10:19:06 INFO unit.neutron- api/0.juju- log server.go:254 Couldn't acquire DPKG lock. Will retry in 10 seconds.
unit-neutron-
unit-neutron-
unit-neutron-
unit-neutron-
This actually related to a network access problem that I had - once that was sorted out, I was able to get the neutron-api service running; however it does highlight a bug in the neutron-api charm (apt_update is called in non fatal mode):
https:/ /bugs.launchpad .net/charms/ +source/ neutron- api/+bug/ 1527230
No action required as part of this review - we'll get that fixed under separate cover.
c) switch tests to use landed midonet changes
We still have outstanding changes for neutron-api and nova-cloud- controller, but keystone and nova-compute can use the main charm-store charms now I think.
d) memory requirements for units
Anything with midonet-agent installed appears to need > 2G of RAM to actually operate as the java heap size for midolman is not dynamically configured based on avaliable memory.
I increased the mem constraint on the services that use this sub to work around that in my testenv (default unit only has 1.5G of RAM).
e) wedged hook execution
Once everything was deployed I noticed:
root 9579 0.0 1.1 419792 17128 ? Ssl 12:23 0:00 /var/lib/ juju/tools/ machine- 3/jujud machine --data-dir /var/lib/juju --machine-id 3 --debug juju/tools/ unit-midonet- api-0/jujud unit --data-dir /var/lib/juju --unit-name midonet juju/agents/ unit-midonet- api-0/charm/ hooks/host- relation- changed
root 9623 0.0 1.3 331612 20420 ? Ssl 12:23 0:00 /var/lib/
root 19731 0.0 1.5 84144 23392 ? S 12:34 0:00 \_ python /var/lib/
host-relation- changed was never returning - this causes the amulet tests to hang as the state on the agent sticks a 'executing'
f) midonet-agent on nova-compute
midolman never actually go installed - this is not propagated back to the charm, so the deployment looks OK, but its not actually complete.
2015-12-17 12:30:01 INFO zookeeper- relation- changed ^[[1;31mError: /Stage[ main]/Midonet: :Midonet_ agent:: Install/ Package[ midolman] /ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options: :=--force- confold install midolman' returned 100: Reading package lists... relation- changed Building dependency tree... relation- changed Reading state information... relation- changed E: Unable to locate package midolman relation- changed ^[[0m relation- changed ^[[mNotice: /Stage[ main]/Midonet: :Midonet_ agent:: Run/File[ /etc/midolman/ midolman. conf]: Dependency Package[midolman] has failures: true^[[0m relation- changed ^[[1;31mWarning: /Stage[ main]/Midonet: :Midonet_ agent:: Run/File[ /etc/midolman/ midolman. conf]: Skipping because of failed dependencies^[[0m relation- changed ^[[mNotice: /Stage[ main]/Midonet: :Midonet_ agent:: Run/Service[ midolman] : Dependency Package[midolman] has failures: true^[[0m relation- changed ^[[1;31mWarning: /Stage[ main]/Midonet: :Midonet_ agent:: Run/Service[ midolman] : Skipping because of failed dependencies^[[0m relation- changed ^[[mNotice: Finished catalog run in 0.50 seconds^[[0m
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
2015-12-17 12:30:01 INFO zookeeper-
Any changes I made to the amulet tests I've proposed back to you under:
https:/ /code.launchpad .net/~james- page/charms/ trusty/ midonet- api/review- fixes/+ merge/280843