Comment 3 for bug 1446999

Revision history for this message
Uma (umasv1987) wrote :

Hi Johns,
                     Thanks for reviewing the code and I have taken care of icon.svg template and website relation changed hook comments.

For the first comment regarding was-url and im_file_name ideally we should change these parameters and these are being used only once to download binaries from repository thats why its done in install hook rather than config-changed hook,.

Now i m not giving any default value for was_url and this needs to be entered from the user and added to validation to check the same .

Given option for im_install_path in config.yaml , by this value user can choose his installation path

We have given diff option for was_url and im_file_name because user can have any version of IM with 1.6 and above and hence its file name will be varying. If i append im_file_name with was_url , we will be not able to download other WAS binaries. so given diff option for both.

I have taken care of your comments ,Please review and let me know your comments