Juju Charms Collection

  1. Bug #1446966
  2. Comment #17

Comment 17 for bug 1446966

Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Hi Geetha,

Thank you for your work on this charm. Here are some issues that may require your attention:

- Building the layer failed for me because (I think) some of the interfaces were not registered in http://interfaces.juju.solutions/ . Can you please make sure all the interfaces and layers used are registered and submitted for review?

- I've seen a number of code style errors. You can spot them by running "make lint" inside the build output directory.

- In the README you are using "juju set" however this has been replaced by "juju config" in Juju 2.0. Could you update the instructions?

- Can you make sure that the tests are running & passing without using any non promulgated charms? We cannot establish the correctness of a charm when using items we do not know they work. If you need to test multiple charms you can submit a bundle for review.

Thank you for your time,
Konstantinos