Juju Charms Collection

  1. Bug #1446173
  2. Comment #3

Comment 3 for bug 1446173

Revision history for this message
Rob Day (rkd-u) wrote :

Hi Charles,

Apologies for the delay here, but we've now applied your feedback and pushed it to https://github.com/Metaswitch/clearwater-juju/tree/master/charms/precise/clearwater-bono.

Taking your feedback comments specifically:

- We've renamed categories to tags
- Fetching an installer for chef-solo - since this installer is open-source, we've just made it part of the charm to resolve this issue
- Use of the AWS Metadata URL - we've removed this now that the corresponding Juju fix is in, and tested on openStack
- `hooks/upgrade-charm` calling `hooks/config-changed` - we've removed this
- Hooks for `dns-agent-relation-departed` or `dns-agent-relation-broken` - we've changed our DNS provider to https://github.com/chuckbutler/DNS-Charm, and that doesn't yet implement a departed relationship (https://github.com/chuckbutler/DNS-Charm/issues/8)
- Amulet tests - we've added one, and noting your positive comments about reuse, we've just made it a lightweight wrapper around our existing test infrastructure