Comment 2 for bug 1440161

Hi Cory,

Thanks for all of your work on the bundle and related charms, and the refactoring of the services framework in charmhelpers.

For the bundle and charms, you have my +1. I was able to deploy them successfully, using Amazon, with no issue and the tests passed cleanly.

As for the charmhelpers branch, I have to give it a -1 at the moment. While I'm excited to see this new version of the services framework, I note a couple of issues:
- The old charmhelpers.core.services api is missing, breaking backwards compatibility. I wonder if there's a better way to handle this kind of refactoring. A versioned namespace, perhaps, or turning charmhelpers.core.services into a compatibility layer so that charms using the existing services framework "just work" and can benefit from some of the bug fixes in the new framework.
- There are a few lint errors:
    Checking for Python syntax...
    charmhelpers/contrib/bigdata/handlers/apache.py:246:13: E265 block comment should start with '# '
    charmhelpers/contrib/bigdata/handlers/apache.py:267:17: E265 block comment should start with '# '
    charmhelpers/contrib/bigdata/handlers/apache.py:380:13: E265 block comment should start with '# '
    make: *** [lint] Error 1
- Make test has several errors
- charmhelpers.core.charmframework.base and .helpers have very low test coverage. I'd love to see that expanded.