Juju Charms Collection

Bug #1432489
Comment #7

Comment 7 for bug 1432489

Revision history for this message

Antonio Rosales (arosales) wrote on 2015-04-02:

@Vsr,

Thank you for the updates to the README to clarify the license acceptance process.

To confirm on the binaries:
> It is not feasible to ship the binaries themselves as they are licensed.

Understood the binaries are licensed, however can you help me understand how they are licensed so we can find the best way forward for users. Does a user have to set a license key on deploy of the MQ software, or before downloading the software? Also said another way, does the MQ software work without a user setting a license key?

I also have the following comments that need addressed per my initial review:
>> Specify the exact location in the README.md where the IBM MQ license can be obtained.

Given there are a lot of questions on how to obtain the MQ software from the review potential users may also run into this. Suggest to detail how the users gets the MQ binary (what URL to visit, what web workflow to follow, what points to take note of during the web workflow), and then once the user downloads the binary detail how the user places the binary into the charm so it can be deployed locally. Also note in the caveats that the charm must be deployed locally if we can not ship the binaries in the charm and license set. Also suggest how the user can download the "BM MQ 90 day no-charge trial."

Also suggest in the "Overview" to tell what the charm does and a link to more information, such as:
http://www-03.ibm.com/software/products/en/ibm-mq
as the "IBM MQ Information" section links to the license and not the readme. Given that suggest in the "IBM MQ Information" section have two links; (1) General info and (2) license.

On a side note if you want your system configuration parameters to read as code (which does read nicer) you'll need to follow the indention MarkDown rules at:
https://guides.github.com/features/mastering-markdown/

For now I'll move this bug into "Incomplete" while the above items are addressed. Please update the status to "Fix Committed" when you are ready for another review. Thanks again for your work on this charm to ensure a great user experience.

We can work separately on how to test the charm for the review and in CI going forward.

-thanks
Antonio

@Vsr,

Thank you for the updates to the README to clarify the license acceptance process.

To confirm on the binaries:
> It is not feasible to ship the binaries themselves as they are licensed.

Understood the binaries are licensed, however can you help me understand how they are licensed so we can find the best way forward for users. Does a user have to set a license key on deploy of the MQ software, or before downloading the software?  Also said another way, does the MQ software work without a user setting a license key?

I also have the following comments that need addressed per my initial review:
>> Specify the exact location in the README.md where the IBM MQ license can be obtained.

Also suggest in the "Overview" to tell what the charm does and a link to more information, such as:
  http://www-03.ibm.com/software/products/en/ibm-mq
as the "IBM MQ Information" section links to the license and not the readme. Given that suggest in the "IBM MQ Information" section have two links; (1) General info and (2) license.

On a side note if you want your system configuration parameters to read as code (which does read nicer) you'll need to follow the indention MarkDown rules at:
  https://guides.github.com/features/mastering-markdown/

For now I'll move this bug into  "Incomplete" while the above items are addressed.  Please update the status to "Fix Committed" when you are ready for another review. Thanks again for your work on this charm to ensure a great user experience.

We can work separately on how to test the charm for the review and in CI going forward.

-thanks
Antonio