Comment 23 for bug 1432489

Vsasi,

I got the gzip error mentioned above on the development download mentioned in the README, as well.

Additionally, I noticed some formatting issues in the README, which I took the liberty of cleaning up for you in lp:~johnsca/charms/trusty/ibm-mq/review (https://code.launchpad.net/~johnsca/charms/trusty/ibm-mq/review).

In that branch, I also made some suggested improvements to the test case, changing the amulet.raise_status() calls to asserts, since raise_status() is not handled properly by the test runners such as bundletester, which is our standard test runner for review and automated testing, and always cause the test to report as failure. Additionally, the tests/bundles.yaml file was marked as executable, causing bundletester to attempt to run it.

Finally, in the test, I noticed that it was simply repeating some of the configuration steps from the charm, instead of checking to ensure that the charm performed the steps correctly. For example, instead of having the test attempt to add the ubuntu user to the mqm group, I changed it to use the "groups" command to verify that it was added successfully to the group by the charm. There were a couple of cases at the bottom of the test, for starting the charm's services, that I wasn't sure how to convert to checks instead of attempts to re-perform the steps from the charm.