Comment 2 for bug 1432489

Hello, and thanks again for your contribution to the Juju community.

In reviewing your charm I had the following comments:

Clarify license acceptance:
 - In the README.md suggest under the "Usage" section, as done in the "Configuration" section, to specifically tell the user that license file can only be read after downloading and extracting the IBM MQ contents to files/archive. I was initially under the impression that I could read the terms and conditions in files/archive before downloading the IBM MQ contents.
 - Given that the README.md tells me the license can be read only after downloading the IBM MQ software and extracting into files/archive the config parameter, "accept-ibm-mq-license" is a little confusing as it states the IBM-MQ-license.txt in the root directory must be read and accepted. This file is also of type "data" and not text.

If a license needs to be set in order for the software to work suggest to provide the IBM MQ binary in the charm with the terms and conditions that must be set to true per a specified license/terms-of-conditions text file as already done with the accept-ibm-mq-license config option. A new config option can then be made to set the license key.

Specify the exact location in the README.md where the IBM MQ license can be obtained.

-thanks,
Antonio