Comment 18 for bug 1431045

Revision history for this message
Adam Israel (aisrael) wrote : Re: New charm: gpfs

Hi Suchitra,

I had the chance to review the gpfs charm today. I've primarily focused on getting the binaries installed so that we can do a functional test of the charm. Unfortunately, I ran into a few issues.

I downloaded the tarball that you provided. Here are its contents:

.
├── gpfs_4.1.0
│   └── Linux
│   └── x86_64
│   ├── gpfs.base-4.1.0-0.x86_64.rpm
│   ├── gpfs.base_4.1.0-0_amd64.deb
│   ├── gpfs.crypto-4.1.0-0.x86_64.rpm
│   ├── gpfs.crypto_4.1.0-0_amd64.deb
│   ├── gpfs.docs-4.1.0-0.noarch.rpm
│   ├── gpfs.docs_4.1.0-0_all.deb
│   ├── gpfs.ext-4.1.0-0.x86_64.rpm
│   ├── gpfs.ext_4.1.0-0_amd64.deb
│   ├── gpfs.gpl-4.1.0-0.noarch.rpm
│   ├── gpfs.gpl_4.1.0-0_all.deb
│   ├── gpfs.gskit-8.0.50-16.x86_64.rpm
│   ├── gpfs.gskit_8.0.50-16_amd64.deb
│   ├── gpfs.msg.en-us_4.1.0-0_all.deb
│   └── gpfs.msg.en_US-4.1.0-0.noarch.rpm
├── gpfs_4.1.0.7
│   └── x86_64
│   ├── README
│   ├── changelog
│   ├── gpfs.base-4.1.0-7.x86_64.update.rpm
│   ├── gpfs.base_4.1.0-7_amd64_update.deb
│   ├── gpfs.crypto-4.1.0-7.x86_64.update.rpm
│   ├── gpfs.crypto_4.1.0-7_amd64_update.deb
│   ├── gpfs.docs-4.1.0-7.noarch.rpm
│   ├── gpfs.docs_4.1.0-7_all.deb
│   ├── gpfs.ext-4.1.0-7.x86_64.update.rpm
│   ├── gpfs.ext_4.1.0-7_amd64_update.deb
│   ├── gpfs.gpl-4.1.0-7.noarch.rpm
│   ├── gpfs.gpl_4.1.0-7_all.deb
│   ├── gpfs.gskit-8.0.50-32.x86_64.rpm
│   ├── gpfs.gskit_8.0.50-32_amd64.deb
│   ├── gpfs.msg.en-us_4.1.0-7_all.deb
│   └── gpfs.msg.en_US-4.1.0-7.noarch.rpm
└── ibm_gpfs_canonical.tar

The instructions in the README do not match the contents of the tarball on several points:

- the file name is different
- the version has changed
- there is no gpfs4.1_patches directory, which the install hook expects to exist

With my gpfs_url set to "http://10.0.3.1/gpfs_4.1.0", it attempts to fetch the Packages file via:

http://10.0.3.1/gpfs_4.1.0/gpfs4.1_patches/Linux/x86_64/./Packages

The patches, however, seem to be in the gpfs_4.1.0.7 directory, and has no Linux folder.

Follow-up Actions:
- I'd like to see either a tarball that matches the instructions in the README and/or an update to the README to reflect current installation instructions
- More detail added on the steps a user must take to install and configure the repository for installation. This should be an opinionated set of instructions, from where to extract the downloaded files, such as /srv/gpfs, and what configurations need to be made to apache2 in order for those files to be served back to the charm.

It would be nice to see a more user-friendly method for installing the binaries. I know this has been discussed before, and I'm satisfied with the current method, so long as the instructions to do so are well-documented.

Thanks again for your work on getting the charm ready to go! I'll move the charm's status back to In Progress. Once you're ready, move it back to Fix Committed and we'll take another look.