Comment 7 for bug 1430796

Revision history for this message
Cory Johns (johnsca) wrote :

Phillip,

The changes look good, and the new test looks good and passes as expected. However, to work properly with the automated test runner, the 10-deploy-test.py file should be marked executable.

Regarding the passwords, I do think that we can and should avoid the immutable options in this case. I see your point that the SST password is not intended to be modified by the Juju Admin, so my recommendation there would be to generate the password inside the charm and communicate it to the other nodes via the peer relation. To get consistent agreement on the value, you will need some form of leader election, but for this simple case, a "poor man's" leader election in the form of always deferring to the value sent by a lower-numbered unit seems like it would be sufficient.

Perhaps I'm missing something, but I don't see a reason why the MySQL root password, if it is configurable at all, shouldn't be modifiable with subsequent `juju set` commands. OTOH, you could take the route of the MySQL charm (https://jujucharms.com/mysql/) and generate it in the charm as well to not have it as a config option at all.