Comment 3 for bug 1430796

Revision history for this message
Cory Johns (johnsca) wrote :

Philip,

I was able to deploy successfully to AWS, so it's unclear what was causing the error that Charles was seeing. I am disinclined to consider it blocking, since I can't see anything in your changes from the upstream that would cause such a failure.

The immutable config is an issue, as it goes against the guidelines (https://jujucharms.com/docs/1.20/authors-charm-best-practice#juju-best-practices-and-tips-from-canonical's-infrastructure-team). However, you are correct that it is an issue with the upstream charm, so I opened a bug against percona-cluster (https://bugs.launchpad.net/charms/+source/percona-cluster/+bug/1436093) and perhaps a joint effort can be made to resolve this issue in both charms at once.

As for the functional test, we generally recommend something like an Amulet test that deploys based on the instructions from the README and performs at least some basic checks to confirm that the service is functioning as expected. An example from the apache2 charm is: http://bazaar.launchpad.net/~charmers/charms/trusty/apache2/trunk/view/head:/tests/20-mpm-test.py A functional test of this form would almost certainly apply equally well to the upstream charm, so again, perhaps it can be a joint effort.