Comment 6 for bug 1421230

Hey Cory - I'd like to echo johnsca's sentiment and say thanks for this submission! I look forward to beefing up the Openstack offering with the charms you've created.

To the question you posed in the description, it would indeed be beneficial to submit bird and calico-acl-manager individually. The automated tester is only processing your first charm (neutron-calico).. We'd like to see bird and calico-acl-manager get picked up as well.

The same comment about neutron-calico's Makefile installing test dependencies applies to bird and calico-acl-manager as well. The good news is that once deps are installed, both bird and calico-acl-manager look good from a unit-test perspective. The bad news is that the evil linter has bitten bird:

$ make lint
hooks/setup.py:16:9: F401 'netifaces' imported but unused
hooks/setup.py:21:9: F401 'netaddr' imported but unused
make: *** [lint] Error 1

Something similar to what you did for neutron-calico's lint failures should work for bird too. Once these minor issues are handled, I'd happily +1 these charms. When ready, please do submit bird and calico-acl-manager individually. Thanks!